fix: default to server-defined numInitialChunks MONGOSH-1949 #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
commented
Feb 21, 2025
| reshardOptions.numInitialChunks = options.numInitialChunks; | ||
| } | ||
|
|
||
| if (options?.collation !== undefined) { |
Collaborator
Author
There was a problem hiding this comment.
I'm not 100% sure about this one, but reading the docs for reshardCollection, it appears that there are cases where collation must be included. We would already be passing it correctly to shardCollection, but were previously ignoring it for reshardCollection, which would have resulted in the latter failing.
addaleax
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our default of 1000 for numInitialChunks in
shardAndDistributeCollection. Additionally, it fixes what I believe was a bug where thecollationoption was ignored when callingreshardCollection.